Anonymous Coward (816) has posted comments on this change. ( http://gerrit.cloudera.org:8080/21575 )
Change subject: IMPALA-13221: Calcite: Enable tpcds and tpch queries ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/21575/17/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ExtractLiteralAgg.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ExtractLiteralAgg.java: http://gerrit.cloudera.org:8080/#/c/21575/17/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ExtractLiteralAgg.java@48 PS17, Line 48: public class ExtractLiteralAgg extends RelOptRule { > but it will have performace regression if we do not have "CTE Materializati for exampe tpcds-q67 +--LogicalLimit () (12599) +--LogicalSelect ( predicate list [..rank() <= 100]) (12598) +--LogicalWindow () (12587) +--LogicalLimit () (12584) +--LogicalAgg () (12370) <--- multi agg +--LogicalInnerJoin ([..ss_item_sk = ..i_item_sk] ) (12268) |--LogicalInnerJoin ([..ss_store_sk = ..s_store_sk] ) (12240) | |--LogicalInnerJoin ([..ss_sold_date_sk = ..d_date_sk] ) (12205) | | |--LogicalGet ( (tpcds.store_sales) ) (12145) | | +--LogicalGet ( (tpcds.date_dim) [..d_month_seq <= 1211, ..d_month_seq >= 1200] ) (12169) | +--LogicalGet ( (tpcds.store) ) (12209) +--LogicalGet ( (tpcds.item) ) (12244) the plan fragement below LogicalAgg () (12370) will recompute many times if we do not have "CTE Materialization" so AggregateMultipleExpandRule will no use if we do not have "CTE Materialization" -- To view, visit http://gerrit.cloudera.org:8080/21575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3107d336ac07ecd89530b640165798ec6a574f41 Gerrit-Change-Number: 21575 Gerrit-PatchSet: 17 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2024 13:18:32 +0000 Gerrit-HasComments: Yes
