Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21575 )
Change subject: IMPALA-13221: Calcite: Enable tpcds and tpch queries ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/21575/17/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ExtractLiteralAgg.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ExtractLiteralAgg.java: http://gerrit.cloudera.org:8080/#/c/21575/17/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ExtractLiteralAgg.java@48 PS17, Line 48: public class ExtractLiteralAgg extends RelOptRule { > for exampe tpcds-q67 So the current plan is to get as many queries running as possible. This specific commit ensures that tpcds and tpch will work which gives us some confidence that a lot of general queries will work. I currently have some patches locally that address performance (though there is still work to be done, even on top of that). Some of the current things under development are handling partition pruning, adding lots more rules, and dealing with stats and keys that determine join ordering. If you can do me a favor: Please file a Jira for this as a potential optimization. There is an umbrella Jira, IMPALA-12871, being used for this, so if you can create a sub-task here, that would be great, thanks! -- To view, visit http://gerrit.cloudera.org:8080/21575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3107d336ac07ecd89530b640165798ec6a574f41 Gerrit-Change-Number: 21575 Gerrit-PatchSet: 17 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2024 13:49:43 +0000 Gerrit-HasComments: Yes
