Zihao Ye has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21701 )

Change subject: IMPALA-12957: Support reading Inf and NaN from JSON
......................................................................


Patch Set 1:

(1 comment)

Thank you for the review!

http://gerrit.cloudera.org:8080/#/c/21701/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21701/1//COMMIT_MSG@19
PS1, Line 19: https://github.com/Tencent/rapidjson/issues/2299
> I see this is resolved. Do you know if rapidjson will have a new release to
It seems that there are no plans for a new release of rapidjson in the near 
future, so we might need to handle this ourselves. I have submitted a commit to 
native-toolchain to include the fix:
https://gerrit.cloudera.org/#/c/21980/
Once it is merged, we can revisit this issue.



--
To view, visit http://gerrit.cloudera.org:8080/21701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05ee7c7c7fb7e78fff9570f659ce2d13c94a4e10
Gerrit-Change-Number: 21701
Gerrit-PatchSet: 1
Gerrit-Owner: Zihao Ye <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zihao Ye <[email protected]>
Gerrit-Comment-Date: Mon, 28 Oct 2024 08:10:30 +0000
Gerrit-HasComments: Yes

Reply via email to