Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/21825 )
Change subject: IMPALA-889: Add trim() function matching ANSI SQL definition ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/21825/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21825/12//COMMIT_MSG@41 PS12, Line 41: ODE que > Ok, he wrote that informally in a comment here, but I don't think the sente Done http://gerrit.cloudera.org:8080/#/c/21825/12/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java File fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java: http://gerrit.cloudera.org:8080/#/c/21825/12/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java@85 PS12, Line 85: // For special case: "select trim(table_column from 'string') from table" > | As table_column makes sense only for charset Didn't get your point. <where> can be one LEADING, TRAILING or BOTH, so your example is perfectly fine and is handled by the generic constructor, which comes after this one. One thing I noticed though is missing <> around where in the comment for generic constructor, perhaps that was causing confusion. Fixed. About the comment, please not that this constructor goes after the <charset> one, hinting the relation. But meanwhile I got an idea for even more obvious comment. Changing here and in related .cup section. http://gerrit.cloudera.org:8080/#/c/21825/12/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java@148 PS12, Line 148: super.getParams().size() == 1 > Wouldn't a Precondition check more appropriate then? Pehraps, changed. -- To view, visit http://gerrit.cloudera.org:8080/21825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c4fa6d0d8d0684c4b6d8dac8fd531d205e4f7b4 Gerrit-Change-Number: 21825 Gerrit-PatchSet: 15 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 30 Oct 2024 21:23:37 +0000 Gerrit-HasComments: Yes
