Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/21825 )
Change subject: IMPALA-889: Add trim() function matching ANSI SQL definition ...................................................................... Patch Set 16: (3 comments) http://gerrit.cloudera.org:8080/#/c/21825/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21825/15//COMMIT_MSG@44 PS15, Line 44: UTF8 mode > Nit: I'd leave it as "UTF8 mode" because 'UTF8_MODE' is the name of the spe Done http://gerrit.cloudera.org:8080/#/c/21825/12/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java File fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java: http://gerrit.cloudera.org:8080/#/c/21825/12/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java@85 PS12, Line 85: // Special case for "TRIM(<charset> FROM <string>)": charset is a simple slot reference. > | Changing here and in related .cup section. Hmm, no idea what happened. Should be good in newest udpate. http://gerrit.cloudera.org:8080/#/c/21825/12/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java@148 PS12, Line 148: super.getParams().size() == 1 > Pehraps, changed. However, Preconditions won't do here. In sort of queries with simple column reference, AnalyzeImpl() gets called multiple times. I don't know it's a bug or feature, but it works like that for generic FunctionExpr functions as well. -- To view, visit http://gerrit.cloudera.org:8080/21825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c4fa6d0d8d0684c4b6d8dac8fd531d205e4f7b4 Gerrit-Change-Number: 21825 Gerrit-PatchSet: 16 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 31 Oct 2024 17:52:37 +0000 Gerrit-HasComments: Yes
