Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21825 )
Change subject: IMPALA-889: Add trim() function matching ANSI SQL definition ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/21825/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21825/15//COMMIT_MSG@44 PS15, Line 44: UTF8_MODE Nit: I'd leave it as "UTF8 mode" because 'UTF8_MODE' is the name of the specific query option. http://gerrit.cloudera.org:8080/#/c/21825/12/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java File fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java: http://gerrit.cloudera.org:8080/#/c/21825/12/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java@85 PS12, Line 85: // For special case: "select trim(table_column from 'string') from table" > Didn't get your point. <where> can be one LEADING, TRAILING or BOTH, so you | Changing here and in related .cup section. Did you want to change these in PS15? There is no change there. The same with L148. -- To view, visit http://gerrit.cloudera.org:8080/21825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c4fa6d0d8d0684c4b6d8dac8fd531d205e4f7b4 Gerrit-Change-Number: 21825 Gerrit-PatchSet: 15 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 31 Oct 2024 16:20:40 +0000 Gerrit-HasComments: Yes
