Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22010 )
Change subject: IMPALA-13502: Clean up around constructors ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22010/3/be/src/codegen/codegen-anyval-read-write-info.h File be/src/codegen/codegen-anyval-read-write-info.h: http://gerrit.cloudera.org:8080/#/c/22010/3/be/src/codegen/codegen-anyval-read-write-info.h@175 PS3, Line 175: llvm::PHINode* CodegenNullPhiNode( : llvm::Value* non_null_value, llvm::Value* null_value, const std::string& name); nit: FilterContext::CodegenEval, FilterContext::CodegenInsert, and KrpcDataStreamSenderConfig::CodegenHashRow all call this with same "val_ptr_phi" name. CodegenAnyVal::CreateFromReadWriteInfo and HashTableCtx::CodegenEvalRow has same "is_null_phi" name. Can that names be static constexpr? They seem significant. -- To view, visit http://gerrit.cloudera.org:8080/22010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4321888808a6b26f42664163e1d1fa137dbc7d14 Gerrit-Change-Number: 22010 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 01 Nov 2024 16:01:51 +0000 Gerrit-HasComments: Yes
