Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22010 )
Change subject: IMPALA-13502: Clean up around constructors ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22010/3/be/src/codegen/codegen-anyval-read-write-info.h File be/src/codegen/codegen-anyval-read-write-info.h: http://gerrit.cloudera.org:8080/#/c/22010/3/be/src/codegen/codegen-anyval-read-write-info.h@175 PS3, Line 175: llvm::PHINode* CodegenNullPhiNode( : llvm::Value* non_null_value, llvm::Value* null_value, const std::string& name); > nit: They tend to be context-specific, I'm not sure it makes sense to couple them. And they share the same entry in .data; I'll double check that actually happens. -- To view, visit http://gerrit.cloudera.org:8080/22010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4321888808a6b26f42664163e1d1fa137dbc7d14 Gerrit-Change-Number: 22010 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 01 Nov 2024 18:14:03 +0000 Gerrit-HasComments: Yes
