Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22010 )

Change subject: IMPALA-13502: Clean up around constructors
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22010/3/be/src/exec/tuple-file-writer.cc
File be/src/exec/tuple-file-writer.cc:

http://gerrit.cloudera.org:8080/#/c/22010/3/be/src/exec/tuple-file-writer.cc@82
PS3, Line 82:   CharMemTrackerAllocator allocator(tracker_);
            :   OutboundRowBatch out(allocator);
> Can this reused between multiple Write() ?
Yeah, looks like it.



--
To view, visit http://gerrit.cloudera.org:8080/22010
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4321888808a6b26f42664163e1d1fa137dbc7d14
Gerrit-Change-Number: 22010
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Fri, 01 Nov 2024 21:44:24 +0000
Gerrit-HasComments: Yes

Reply via email to