Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries during planning ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/21803/10/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/21803/10/be/src/runtime/query-driver.cc@496 PS10, Line 496: QueryHandle* query_handle, const Status* cause) { Please mention in the commit message why the removal of check_inflight will not re-introduce the issue fixed in https://github.com/apache/impala/commit/54642b2549c38625c868f09815b61170e568cdb9 http://gerrit.cloudera.org:8080/#/c/21803/10/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/21803/10/fe/src/main/java/org/apache/impala/service/Frontend.java@2050 PS10, Line 2050: // 2. This thread clears execRequestThreads_ and cancelledThreads_ I'm not seeing where this case happens. -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 06 Nov 2024 16:20:21 +0000 Gerrit-HasComments: Yes
