Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries during planning ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/21803/10/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/21803/10/be/src/runtime/query-driver.cc@496 PS10, Line 496: if (!finalized_.CompareAndSwap(false, true)) { > Please mention in the commit message why the removal of check_inflight will Done http://gerrit.cloudera.org:8080/#/c/21803/10/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/21803/10/fe/src/main/java/org/apache/impala/service/Frontend.java@2050 PS10, Line 2050: // cancelExecRequest contains a fallback in case that happens. > I'm not seeing where this case happens. Lines 2046 and 2054? I've moved the comment up. http://gerrit.cloudera.org:8080/#/c/21803/10/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/21803/10/fe/src/main/java/org/apache/impala/service/JniFrontend.java@195 PS10, Line 195: Frontend.cancelExecRequest(queryId); > cancelExecRequest is a static method and should be called statically: Fron Done -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 08 Nov 2024 00:04:07 +0000 Gerrit-HasComments: Yes
