Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22014 )
Change subject: IMPALA-13154: Update stats when loading an HDFS table ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/22014/9/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/22014/9/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@363 PS9, Line 363: // Initializes the values of the storage stats. : public void init() { : numFiles = 0; : numBlocks = 0; : totalFileBytes = 0; : } nit: we can also remove this since the default values of numeric fields in Java are all 0. https://docs.oracle.com/javase/tutorial/java/nutsandbolts/datatypes.html -- To view, visit http://gerrit.cloudera.org:8080/22014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e2eb503b0f61b1e6403058bc5dc78d721e7e940 Gerrit-Change-Number: 22014 Gerrit-PatchSet: 9 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 06 Nov 2024 23:18:40 +0000 Gerrit-HasComments: Yes
