Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/22014 )
Change subject: IMPALA-13154: Update stats when loading an HDFS table ...................................................................... Patch Set 10: (2 comments) > Patch Set 9: > > (1 comment) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/22014/9/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/22014/9/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@846 PS9, Line 846: fileMetadataStats_ = fileMetadataStats; : } : : pub > nit: Can we simply use "fileMetadataStats_ = fileMetadataStats" ? Thanks! Changed and added a note. http://gerrit.cloudera.org:8080/#/c/22014/9/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/22014/9/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@363 PS9, Line 363: // Initializes the values of the storage stats. : public void init() { : numFiles = 0; : numBlocks = 0; : totalFileBytes = 0; : } > nit: we can also remove this since the default values of numeric fields in Thanks! Removed a call in updateStatistics(). But it seems that init() is also used in HdfsTable.resetPartitions(). -- To view, visit http://gerrit.cloudera.org:8080/22014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e2eb503b0f61b1e6403058bc5dc78d721e7e940 Gerrit-Change-Number: 22014 Gerrit-PatchSet: 10 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 07 Nov 2024 07:31:19 +0000 Gerrit-HasComments: Yes
