Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/22014 )
Change subject: IMPALA-13154: Update stats when loading an HDFS table ...................................................................... Patch Set 12: (2 comments) > Patch Set 10: Code-Review+1 > > (3 comments) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/22014/10/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/22014/10/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@765 PS10, Line 765: // File statistics corresponding to the encoded file descriptors. > nit: Can we add some comments like other fields? E.g. saying that these are Thanks! Added. http://gerrit.cloudera.org:8080/#/c/22014/10/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@1277 PS10, Line 1277: : public static class Builder { > nit: We can add a precondition check in build() and add a boolean field to Thanks! The new Patch Set is trying to make Builder objects reusable. -- To view, visit http://gerrit.cloudera.org:8080/22014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e2eb503b0f61b1e6403058bc5dc78d721e7e940 Gerrit-Change-Number: 22014 Gerrit-PatchSet: 12 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Tue, 12 Nov 2024 10:26:49 +0000 Gerrit-HasComments: Yes
