Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22014 )
Change subject: IMPALA-13154: Update stats when loading an HDFS table ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/22014/12/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/22014/12/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java@162 PS12, Line 162: } Maybe it's more clear to set FileMetadataStats here and collect it inside FileMetadataLoader.load(), as Noemi discussed in the JIRA: https://issues.apache.org/jira/browse/IMPALA-13154?focusedCommentId=17898606&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17898606 -- To view, visit http://gerrit.cloudera.org:8080/22014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e2eb503b0f61b1e6403058bc5dc78d721e7e940 Gerrit-Change-Number: 22014 Gerrit-PatchSet: 12 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 18 Nov 2024 07:01:50 +0000 Gerrit-HasComments: Yes
