Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22119 )
Change subject: IMPALA-13536: Fix Workload Management Init Tests Issues ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/22119/1/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22119/1/tests/common/custom_cluster_test_suite.py@377 PS1, Line 377: Waits for the catalog to report the workload management initialization process has > Did we talk about replacing this with a check like `describe sys.impala_que Yeah, we talked about it. I went with log message assertions because some tests assert on the number of queries executed, and "describe sys.impala_query_..." would have to be executed a non-deterministic number of times. http://gerrit.cloudera.org:8080/#/c/22119/1/tests/custom_cluster/test_workload_mgmt_init.py File tests/custom_cluster/test_workload_mgmt_init.py: http://gerrit.cloudera.org:8080/#/c/22119/1/tests/custom_cluster/test_workload_mgmt_init.py@186 PS1, Line 186: self.check_schema_version("1.0.0") > This comment no longer applies. Done http://gerrit.cloudera.org:8080/#/c/22119/1/tests/custom_cluster/test_workload_mgmt_init.py@201 PS1, Line 201: > This comment no longer applies. Done -- To view, visit http://gerrit.cloudera.org:8080/22119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f34088d1d925f30abb63471387e6fdb62b95a7 Gerrit-Change-Number: 22119 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 25 Nov 2024 22:42:44 +0000 Gerrit-HasComments: Yes
