Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22119 )
Change subject: IMPALA-13536: Fix Workload Management Init Tests Issues ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22119/2/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22119/2/tests/common/custom_cluster_test_suite.py@510 PS2, Line 510: LOG.info("Log Files for Test:\n{}".format(file_list)) > This log message will only be printed when a test fails. Do you mean when test fail or when start-impala-cluster.py fail? The code seems to print in any case since it is in finally block. Also, if 2 test run and both log to same $IMPALA_LOG_DIR, where the first has cluster size 10 and the second has cluster size 3, then I think impalad_node4.INFO to impalad_node10.INFO will still be there in $IMPALA_LOG_DIR. http://gerrit.cloudera.org:8080/#/c/22119/2/tests/custom_cluster/test_workload_mgmt_init.py File tests/custom_cluster/test_workload_mgmt_init.py: http://gerrit.cloudera.org:8080/#/c/22119/2/tests/custom_cluster/test_workload_mgmt_init.py@193 PS2, Line 193: cluster_size=10 > It's not as important, but still good to test to ensure clusters greater th Seems unnecessary to start 10 nodes to only run the test file against just one of them. I think it is good to randomly pick 1 of impalad as coordinator by setting multiple_impalad=True parameter in run_test_case. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/22119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f34088d1d925f30abb63471387e6fdb62b95a7 Gerrit-Change-Number: 22119 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 26 Nov 2024 00:20:08 +0000 Gerrit-HasComments: Yes
