Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22119 )
Change subject: IMPALA-13536: Fix Workload Management Init Tests Issues ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22119/2/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22119/2/tests/common/custom_cluster_test_suite.py@510 PS2, Line 510: LOG.info("Log Files for Test:\n{}".format(file_list)) This will be printed for all custom cluster tests and becomes a noise. Is it still helpful even though assert.*log_contains function already print out the actual log file path? For example, 10 impalads cluster may print 40 file paths for all INFO, WARNING, ERROR, and FATAL. If test does set specific impalad_log_dir, it may print all resolved paths for old symlinks left behind under /tmp/. http://gerrit.cloudera.org:8080/#/c/22119/2/tests/custom_cluster/test_workload_mgmt_init.py File tests/custom_cluster/test_workload_mgmt_init.py: http://gerrit.cloudera.org:8080/#/c/22119/2/tests/custom_cluster/test_workload_mgmt_init.py@193 PS2, Line 193: cluster_size=10 Now that workload management init done by CatalogD, is it still important to vary the cluster size? -- To view, visit http://gerrit.cloudera.org:8080/22119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f34088d1d925f30abb63471387e6fdb62b95a7 Gerrit-Change-Number: 22119 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 25 Nov 2024 22:52:33 +0000 Gerrit-HasComments: Yes
