Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22119 )
Change subject: IMPALA-13536: Fix Workload Management Init Tests Issues ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22119/2/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22119/2/tests/common/custom_cluster_test_suite.py@510 PS2, Line 510: LOG.info("Log Files for Test:\n{}".format(file_list)) > Yeah, I'm also not sure this is that helpful. Finding the right file by tim This log message will only be printed when a test fails. When the logfile assertion functions fail, they print the log file that was examined but do not print out other files for the cluster. When diagnosing build failures, I have frequently found myself looking across log files, and identifying the exact files to review is difficult especially for tests that run close together. The start-impala-cluster.py script removes old symlinks. since impala_log_dir is also passed to the start-impala-cluster.py script, there will not be any old sym links listed here. http://gerrit.cloudera.org:8080/#/c/22119/2/tests/custom_cluster/test_workload_mgmt_init.py File tests/custom_cluster/test_workload_mgmt_init.py: http://gerrit.cloudera.org:8080/#/c/22119/2/tests/custom_cluster/test_workload_mgmt_init.py@193 PS2, Line 193: cluster_size=10 > Now that workload management init done by CatalogD, is it still important t It's not as important, but still good to test to ensure clusters greater than 3 nodes do not have communication issues. -- To view, visit http://gerrit.cloudera.org:8080/22119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f34088d1d925f30abb63471387e6fdb62b95a7 Gerrit-Change-Number: 22119 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 25 Nov 2024 23:58:13 +0000 Gerrit-HasComments: Yes
