Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22119 )
Change subject: IMPALA-13536: Fix Workload Management Init Tests Issues ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/22119/2/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22119/2/tests/common/custom_cluster_test_suite.py@510 PS2, Line 510: finally: > When start-impala-cluster.py runs, it removes all existing symlinks (at lea Done http://gerrit.cloudera.org:8080/#/c/22119/3/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22119/3/tests/common/custom_cluster_test_suite.py@512 PS3, Line 512: # List log files from this cluster startup to identify log files for failed tests. : file_list = "" : for pattern in ["*.INFO", "*.WARNING", "*.ERROR", "*.FATAL"]: : matching_files = glob(os.path.join(impala_log_dir, pattern)) : for matching_file in sorted(matching_files): : file_list += " * {} - {}\n".format(matching_file.split(os.path.sep)[-1], : os.path.realpath(matching_file)) : LOG.info("Log Files for Test:\n{}".format(file_list)) nit: might want to contain this in its own method. http://gerrit.cloudera.org:8080/#/c/22119/2/tests/custom_cluster/test_workload_mgmt_init.py File tests/custom_cluster/test_workload_mgmt_init.py: http://gerrit.cloudera.org:8080/#/c/22119/2/tests/custom_cluster/test_workload_mgmt_init.py@193 PS2, Line 193: le sql was used > I think it's a good idea to connect to different coordinators. I modified Sorry if I'm not clear before. You don't need to add create_random_impala_client() for this. run_test_case method already facilitate that. def run_test_case(self, test_file_name, vector, use_db=None, multiple_impalad=False, encoding=None, test_file_vars=None): """ Runs the queries in the specified test based on the vector values Runs the query using targeting the file format/compression specified in the test vector and the exec options specified in the test vector. If multiple_impalad=True a connection to a random impalad will be chosen to execute each test section. Otherwise, the default impalad client will be used. If 'protocol' (either 'hs2' or 'beeswax') is set in the vector, a client for that protocol is used. Otherwise we use the default: beeswax. So instead, you can simply do: # Asserts the correct create table sql was used. self.run_test_case('QueryTest/workload-management-log-v1.1.0', vector, self.WM_DB, multiple_impalad=True) self.run_test_case('QueryTest/workload-management-live-v1.1.0', vector, self.WM_DB, multiple_impalad=True) -- To view, visit http://gerrit.cloudera.org:8080/22119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f34088d1d925f30abb63471387e6fdb62b95a7 Gerrit-Change-Number: 22119 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 26 Nov 2024 20:56:14 +0000 Gerrit-HasComments: Yes
