Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 13: (5 comments) http://gerrit.cloudera.org:8080/#/c/21930/13/be/src/service/control-service.cc File be/src/service/control-service.cc: http://gerrit.cloudera.org:8080/#/c/21930/13/be/src/service/control-service.cc@282 PS13, Line 282: status = ExecEnv::GetInstance()->impala_server()->UnregisterQuery( This is essentially like issuing CancelOperation then CloseOperation from the client. Which makes sense, as that's what a client would do to stop running a query. http://gerrit.cloudera.org:8080/#/c/21930/13/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/21930/13/be/src/service/impala-server.h@731 PS13, Line 731: friend class ClientRequestState; // for CancelInternal() and UnregisterQuery() nit: instead of this, I think we could provide an ImpalaServer::KillQuery interface that ControlService::KillQuery and ClientRequestState::TryKillQueryLocally could both use. There's a small amount of shared logic copied between them. http://gerrit.cloudera.org:8080/#/c/21930/13/common/protobuf/control_service.proto File common/protobuf/control_service.proto: http://gerrit.cloudera.org:8080/#/c/21930/13/common/protobuf/control_service.proto@470 PS13, Line 470: optional string requesting_user = 2; > Shoudn't this be required? I think it's omitted if user is an admin, which also means it's automatically accepted. It'd make sense to me to document that behavior here. http://gerrit.cloudera.org:8080/#/c/21930/13/tests/authorization/__init__.py File tests/authorization/__init__.py: PS13: Why was this file added? http://gerrit.cloudera.org:8080/#/c/21930/13/tests/query_test/__init__.py File tests/query_test/__init__.py: PS13: Also seems unnecessary. -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 13 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 19 Dec 2024 00:53:21 +0000 Gerrit-HasComments: Yes
