gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 33: (3 comments) http://gerrit.cloudera.org:8080/#/c/21728/32/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/21728/32/be/src/service/impala-server.cc@3110 PS32, Line 3110: / > return error if both FLAGS_jwt_token_auth and FLAGS_oauth_token_auth are se Impala can support both together. http://gerrit.cloudera.org:8080/#/c/21728/32/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/21728/32/be/src/transport/THttpServer.cpp@330 PS32, Line 330: (has_jwt_ > Here we assume jwt and oauth can not be enabled simultaneously. Please ment They should be independent if blocks. Impala can support both OAuth JWT together. Updated the code. Thanks. http://gerrit.cloudera.org:8080/#/c/21728/32/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/21728/32/shell/impala_client.py@a1169 PS32, Line 1169: > unnecessary change This change is not visible in my local editor. -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 33 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Mon, 13 Jan 2025 02:28:38 +0000 Gerrit-HasComments: Yes