gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 34: (5 comments) http://gerrit.cloudera.org:8080/#/c/21728/33/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/21728/33/be/src/rpc/authentication.cc@1778 PS33, Line 1778: else if > jwt and oauth are independent If the ldap or kerberos is enabled, then all authentication is supported. Otherwise, the existing code only support only one at a time. The if block is more common since we have either the ldap or kerberos enabled. http://gerrit.cloudera.org:8080/#/c/21728/33/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/21728/33/tests/custom_cluster/test_shell_jwt_auth.py@196 PS33, Line 196: > here and below, replace jwt with oauth Done http://gerrit.cloudera.org:8080/#/c/21728/33/tests/custom_cluster/test_shell_jwt_auth.py@213 PS33, Line 213: > oauth Done http://gerrit.cloudera.org:8080/#/c/21728/33/tests/custom_cluster/test_shell_jwt_auth.py@221 PS33, Line 221: > OAuth Done http://gerrit.cloudera.org:8080/#/c/21728/33/tests/custom_cluster/test_shell_jwt_auth.py@225 PS33, Line 225: OAu > OAuth Done -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 34 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Mon, 13 Jan 2025 19:02:56 +0000 Gerrit-HasComments: Yes
