Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 33: (6 comments) http://gerrit.cloudera.org:8080/#/c/21728/33//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21728/33//COMMIT_MSG@23 PS33, Line 23: valid signature but expired. should you add test case in fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java and JwtWebserverTest.java? http://gerrit.cloudera.org:8080/#/c/21728/33/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/21728/33/be/src/rpc/authentication.cc@1778 PS33, Line 1778: else if jwt and oauth are independent http://gerrit.cloudera.org:8080/#/c/21728/33/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/21728/33/tests/custom_cluster/test_shell_jwt_auth.py@196 PS33, Line 196: jwt here and below, replace jwt with oauth http://gerrit.cloudera.org:8080/#/c/21728/33/tests/custom_cluster/test_shell_jwt_auth.py@213 PS33, Line 213: jwt oauth http://gerrit.cloudera.org:8080/#/c/21728/33/tests/custom_cluster/test_shell_jwt_auth.py@221 PS33, Line 221: JWT OAuth http://gerrit.cloudera.org:8080/#/c/21728/33/tests/custom_cluster/test_shell_jwt_auth.py@225 PS33, Line 225: JWT OAuth -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 33 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Mon, 13 Jan 2025 05:46:45 +0000 Gerrit-HasComments: Yes
