Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 34: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21728/34/fe/src/test/java/org/apache/impala/customcluster/JwtWebserverTest.java File fe/src/test/java/org/apache/impala/customcluster/JwtWebserverTest.java: http://gerrit.cloudera.org:8080/#/c/21728/34/fe/src/test/java/org/apache/impala/customcluster/JwtWebserverTest.java@155 PS34, Line 155: "--oauth_token_auth=true --oauth_validate_signature=true --oauth_file_path=%s " line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21728/34/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/21728/34/tests/custom_cluster/test_shell_jwt_auth.py@21 PS34, Line 21: import time flake8: F401 'time' imported but unused http://gerrit.cloudera.org:8080/#/c/21728/34/tests/custom_cluster/test_shell_jwt_auth.py@349 PS34, Line 349: flake8: E501 line too long (92 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 34 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Mon, 13 Jan 2025 19:04:22 +0000 Gerrit-HasComments: Yes
