Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 35: (2 comments) http://gerrit.cloudera.org:8080/#/c/21728/35//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21728/35//COMMIT_MSG@15 PS35, Line 15: then both jwt and oauth a could you add a test case with both jwt and oauth enabled? http://gerrit.cloudera.org:8080/#/c/21728/33/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/21728/33/be/src/rpc/authentication.cc@1679 PS33, Line 1679: bool use_oauth = FLAGS_oauth_token_auth; Do we allow oauth to be used without TLS? -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 35 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Mon, 13 Jan 2025 21:32:21 +0000 Gerrit-HasComments: Yes
