Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 40: (5 comments) http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/util/webserver.cc@716 PS40, Line 716: if (use_jwt_) { : LOG(INFO) << "Invalid JWT token provided: " << bearer_token; : total_jwt_token_auth_failure_->Increment(1); : } : if (use_oauth_) { : LOG(INFO) << "Invalid OAuth token provided: " << bearer_token; : total_oauth_token_auth_failure_->Increment(1); indent spaces http://gerrit.cloudera.org:8080/#/c/21728/40/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java File fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java: http://gerrit.cloudera.org:8080/#/c/21728/40/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@165 PS40, Line 165: verifyOAuthAuthMetrics combine this function with verifyJwtAuthMetrics by passing auth string type http://gerrit.cloudera.org:8080/#/c/21728/40/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@825 PS40, Line 825: // Both JWT and OAuth have 3 successes and 1 failure each. : verifyJwtAuthMetrics(3, 1); : verifyOAuthAuthMetrics(3, 1); keep indent spaces consistent http://gerrit.cloudera.org:8080/#/c/21728/40/tests/custom_cluster/test_shell_oauth_auth.py File tests/custom_cluster/test_shell_oauth_auth.py: http://gerrit.cloudera.org:8080/#/c/21728/40/tests/custom_cluster/test_shell_oauth_auth.py@139 PS40, Line 139: JWT OAuth ? http://gerrit.cloudera.org:8080/#/c/21728/40/tests/custom_cluster/test_shell_oauth_auth.py@183 PS40, Line 183: JWT OAuth ? -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 40 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Tue, 14 Jan 2025 04:54:48 +0000 Gerrit-HasComments: Yes
