Abhishek Sharma has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 )
Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. ...................................................................... Patch Set 10: Hi Jim, Please ignore the last comment. I understand your concern. I checked the current implementation, the same issue holds there as well. HTML DOES NOT respect "newlines" and "tabs". Another point, as per my understanding, this API MUST NOT worry about how it is rendered in HTML. The responsibility of rendering it properly must lie with a frontend component. That is, we SHOULD NOT add HTML line breaks in this API's return string. Please do let me know how should I address your concern. -- To view, visit http://gerrit.cloudera.org:8080/10145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80ab4aad03e0c1f01fecad6b87779531244c28b7 Gerrit-Change-Number: 10145 Gerrit-PatchSet: 10 Gerrit-Owner: Abhishek Sharma <[email protected]> Gerrit-Reviewer: Abhishek Sharma <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Charles Agnello <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 23 May 2018 11:53:55 +0000 Gerrit-HasComments: No
