Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 )
Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. ...................................................................... Patch Set 10: > > (1 comment) > > Hi Jim, in the original implementation > (http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/lang/management/ThreadInfo.java#631), > if number of stack frames are more than the max_limit, an ellipses > is added followed by a newline. > > In my implementation, I removed this piece of code @ line 631 > above. Do you mean that newline is missing? I do not think we need > to add ellipses now. > > Let me know if this is what you are suggesting. I also just realized that this is GPL and so cannot be in our repository: https://www.apache.org/legal/resolved.html#category-x Let me do some research to see how to deal with this. -- To view, visit http://gerrit.cloudera.org:8080/10145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80ab4aad03e0c1f01fecad6b87779531244c28b7 Gerrit-Change-Number: 10145 Gerrit-PatchSet: 10 Gerrit-Owner: Abhishek Sharma <[email protected]> Gerrit-Reviewer: Abhishek Sharma <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Charles Agnello <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 25 May 2018 02:47:57 +0000 Gerrit-HasComments: No
