Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22322 )
Change subject: IMPALA-13658: Enable tuple caching aggregates ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/22322/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22322/4//COMMIT_MSG@12 PS4, Line 12: > Please mention preliminary performance results. We should be seeing massive I can get some small numbers with my local setup: - TPC-H Q1 saves ~10ms out of 130ms - TPC-DS Q9 skips all the scans (estimated 288k rows each), taking 232ms instead of 932ms. Running https://jenkins.impala.io/job/perf-AB-test-ub2004-tuplecache/8/ for a larger comparison. http://gerrit.cloudera.org:8080/#/c/22322/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java File fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java: http://gerrit.cloudera.org:8080/#/c/22322/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@166 PS5, Line 166: String appxMedianAgg = "select appx_median(tinyint_col) from functional.alltypesagg"; Excluded appx_median, test here shows it works. -- To view, visit http://gerrit.cloudera.org:8080/22322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bd13c2813c90d23eb3a70f98068fdcdab97a885 Gerrit-Change-Number: 22322 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2025 22:48:51 +0000 Gerrit-HasComments: Yes
