Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22322 )
Change subject: IMPALA-13658: Enable tuple caching aggregates ...................................................................... Patch Set 4: (1 comment) > Patch Set 3: > > (1 comment) > > This makes sense to me. > > One thing: The appx_median aggregation function is non-deterministic. That > isn't necessarily a problem when returned directly to users. It could be a > problem if it feeds into the build side of a join or influences a runtime > filter at a location that is cached. Do we have a mechanism to mark that already? If not, I'd file it as a follow-on ticket. http://gerrit.cloudera.org:8080/#/c/22322/3/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/22322/3/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@695 PS3, Line 695: // Normalize input cardinality estimate for caching in case stats change. > Nit: We could exclude this to avoid variability if some stats change. Done -- To view, visit http://gerrit.cloudera.org:8080/22322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bd13c2813c90d23eb3a70f98068fdcdab97a885 Gerrit-Change-Number: 22322 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 15 Jan 2025 21:36:41 +0000 Gerrit-HasComments: Yes
