Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22322 )
Change subject: IMPALA-13658: Enable tuple caching aggregates ...................................................................... Patch Set 4: > Patch Set 4: > > (1 comment) > > > Patch Set 3: > > > > (1 comment) > > > > This makes sense to me. > > > > One thing: The appx_median aggregation function is non-deterministic. That > > isn't necessarily a problem when returned directly to users. It could be a > > problem if it feeds into the build side of a join or influences a runtime > > filter at a location that is cached. > > Do we have a mechanism to mark that already? If not, I'd file it as a > follow-on ticket. Should be able to add it to isNondeterministicAcrossQueries. -- To view, visit http://gerrit.cloudera.org:8080/22322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bd13c2813c90d23eb3a70f98068fdcdab97a885 Gerrit-Change-Number: 22322 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2025 19:04:03 +0000 Gerrit-HasComments: No
