Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22322 )
Change subject: IMPALA-13658: Enable tuple caching aggregates ...................................................................... Patch Set 3: (1 comment) This makes sense to me. One thing: The appx_median aggregation function is non-deterministic. That isn't necessarily a problem when returned directly to users. It could be a problem if it feeds into the build side of a join or influences a runtime filter at a location that is cached. http://gerrit.cloudera.org:8080/#/c/22322/3/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/22322/3/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@695 PS3, Line 695: msg.agg_node.setEstimated_input_cardinality(getChild(0).getCardinality()); Nit: We could exclude this to avoid variability if some stats change. -- To view, visit http://gerrit.cloudera.org:8080/22322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bd13c2813c90d23eb3a70f98068fdcdab97a885 Gerrit-Change-Number: 22322 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 15 Jan 2025 20:51:42 +0000 Gerrit-HasComments: Yes
