Wenzhe Zhou has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22134 )

Change subject: IMPALA-12992: Support for Hive JDBC Storage handler tables
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22134/8/tests/custom_cluster/test_ext_data_sources.py
File tests/custom_cluster/test_ext_data_sources.py:

http://gerrit.cloudera.org:8080/#/c/22134/8/tests/custom_cluster/test_ext_data_sources.py@179
PS8, Line 179: TestHiveJdbcTables
Suggest to split the class as two classes for postgres and mysql respectively. 
Setting up mysql docker is not stable, the test case will be skipped if failed 
to setup mysql docker. There is no such issue for postgres. We can run test for 
postgres in core and exhaustive mode, run test for mysql in exhaustive mode.



--
To view, visit http://gerrit.cloudera.org:8080/22134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1674b93a02f43df8c1a449cdc54053cc80d9c458
Gerrit-Change-Number: 22134
Gerrit-PatchSet: 8
Gerrit-Owner: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Sat, 01 Feb 2025 01:53:04 +0000
Gerrit-HasComments: Yes

Reply via email to