Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22134 )
Change subject: IMPALA-12992: Support for Hive JDBC Storage handler tables ...................................................................... Patch Set 9: (8 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22134/9/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/22134/9/tests/custom_cluster/test_ext_data_sources.py@191 PS9, Line 191: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/22134/9/tests/custom_cluster/test_ext_data_sources.py@209 PS9, Line 209: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/22134/9/tests/custom_cluster/test_ext_data_sources.py@209 PS9, Line 209: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22134/9/tests/custom_cluster/test_ext_data_sources.py@222 PS9, Line 222: . flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22134/9/tests/custom_cluster/test_ext_data_sources.py@236 PS9, Line 236: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/22134/9/tests/custom_cluster/test_ext_data_sources.py@313 PS9, Line 313: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/22134/9/tests/custom_cluster/test_ext_data_sources.py@313 PS9, Line 313: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22134/9/tests/custom_cluster/test_ext_data_sources.py@326 PS9, Line 326: . flake8: E501 line too long (98 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/22134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1674b93a02f43df8c1a449cdc54053cc80d9c458 Gerrit-Change-Number: 22134 Gerrit-PatchSet: 9 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 06 Feb 2025 17:33:05 +0000 Gerrit-HasComments: Yes
