Wenzhe Zhou has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22134 )

Change subject: IMPALA-12992: Support for Hive JDBC Storage handler tables
......................................................................


Patch Set 9:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/22134/9/testdata/bin/setup-mysql-env.sh
File testdata/bin/setup-mysql-env.sh:

http://gerrit.cloudera.org:8080/#/c/22134/9/testdata/bin/setup-mysql-env.sh@149
PS9, Line 149: id int,
             :   name varchar(20)
could you create a table with more data types of columns?


http://gerrit.cloudera.org:8080/#/c/22134/9/testdata/bin/setup-mysql-env.sh@153
PS9, Line 153: VALUES (1, 'India');
             : INSERT INTO country (id, name)
             : VALUES (2, 'Russia');
             : INSERT INTO country (id, name)
             : VALUES (3, 'USA');
insert three rows in one insert


http://gerrit.cloudera.org:8080/#/c/22134/9/tests/custom_cluster/test_ext_data_sources.py
File tests/custom_cluster/test_ext_data_sources.py:

http://gerrit.cloudera.org:8080/#/c/22134/9/tests/custom_cluster/test_ext_data_sources.py@231
PS9, Line 231: INVALIDATE METADATA {0}.country_postgres
also need to run IM for country_keystore_postgres table


http://gerrit.cloudera.org:8080/#/c/22134/9/tests/custom_cluster/test_ext_data_sources.py@335
PS9, Line 335: INVALIDATE METADATA {0}.country_mysql
also need to run IM for country_keystore_mysql table



--
To view, visit http://gerrit.cloudera.org:8080/22134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1674b93a02f43df8c1a449cdc54053cc80d9c458
Gerrit-Change-Number: 22134
Gerrit-PatchSet: 9
Gerrit-Owner: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Thu, 06 Feb 2025 18:26:00 +0000
Gerrit-HasComments: Yes

Reply via email to