Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22134 )
Change subject: IMPALA-12992: Support for Hive JDBC Storage handler tables ...................................................................... Patch Set 10: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22134/10/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/22134/10/tests/custom_cluster/test_ext_data_sources.py@302 PS10, Line 302: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/22134/10/tests/custom_cluster/test_ext_data_sources.py@371 PS10, Line 371: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22134/10/tests/custom_cluster/test_ext_data_sources.py@371 PS10, Line 371: "hive.sql.dbcp.password.keystore" = line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/22134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1674b93a02f43df8c1a449cdc54053cc80d9c458 Gerrit-Change-Number: 22134 Gerrit-PatchSet: 10 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 07 Feb 2025 09:00:33 +0000 Gerrit-HasComments: Yes
