Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22362 )
Change subject: IMPALA-13682: Implement missing capabilities in ImpylaHS2Client ...................................................................... Patch Set 5: (10 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22362/5/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22362/5/tests/common/impala_connection.py@164 PS5, Line 164: h flake8: U100 Unused argument 'handle' http://gerrit.cloudera.org:8080/#/c/22362/5/tests/common/impala_connection.py@164 PS5, Line 164: f flake8: U100 Unused argument 'fetch_profile_after_close' http://gerrit.cloudera.org:8080/#/c/22362/5/tests/common/impala_connection.py@175 PS5, Line 175: o flake8: U100 Unused argument 'operation_handle' http://gerrit.cloudera.org:8080/#/c/22362/5/tests/common/impala_connection.py@247 PS5, Line 247: s flake8: U100 Unused argument 'sql_stmt' http://gerrit.cloudera.org:8080/#/c/22362/5/tests/common/impala_connection.py@247 PS5, Line 247: o flake8: U100 Unused argument 'operation_handle' http://gerrit.cloudera.org:8080/#/c/22362/5/tests/common/impala_connection.py@247 PS5, Line 247: m flake8: U100 Unused argument 'max_rows' http://gerrit.cloudera.org:8080/#/c/22362/5/tests/common/impala_connection.py@247 PS5, Line 247: d flake8: U100 Unused argument 'discard_results' http://gerrit.cloudera.org:8080/#/c/22362/5/tests/common/impala_connection.py@256 PS5, Line 256: o flake8: U100 Unused argument 'operation_handle' http://gerrit.cloudera.org:8080/#/c/22362/5/tests/common/impala_connection.py@257 PS5, Line 257: p flake8: U100 Unused argument 'profile_format' http://gerrit.cloudera.org:8080/#/c/22362/5/tests/common/impala_connection.py@777 PS5, Line 777: s flake8: U100 Unused argument 'sql_stmt' -- To view, visit http://gerrit.cloudera.org:8080/22362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac07732424c16338e060c9392100b54337f11b8 Gerrit-Change-Number: 22362 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 07 Feb 2025 18:17:59 +0000 Gerrit-HasComments: Yes
