Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22362 )
Change subject: IMPALA-13682: Implement missing capabilities in ImpylaHS2Client ...................................................................... Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/22362/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22362/4//COMMIT_MSG@15 PS4, Line 15: execute_async > Done Done http://gerrit.cloudera.org:8080/#/c/22362/4//COMMIT_MSG@50 PS4, Line 50: r > Done Done http://gerrit.cloudera.org:8080/#/c/22362/4/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22362/4/tests/common/impala_connection.py@267 PS4, Line 267: > Done Done http://gerrit.cloudera.org:8080/#/c/22362/4/tests/common/impala_connection.py@469 PS4, Line 469: E': INITIALIZED, > Done Done http://gerrit.cloudera.org:8080/#/c/22362/7/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22362/7/tests/common/impala_connection.py@581 PS7, Line 581: cursor_count, self.get_test_protocol(), self.__host_port)) This log message could potentially be confusing. It would be clearer to log something like "closing 1 sync and 2 async hs2 connections to {port}" http://gerrit.cloudera.org:8080/#/c/22362/7/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/22362/7/tests/custom_cluster/test_admission_controller.py@519 PS7, Line 519: client.close() Can the new syntax be used here? with self.cluster.impalads[0].service.create_client_from_vector(vector) as client: http://gerrit.cloudera.org:8080/#/c/22362/7/tests/custom_cluster/test_admission_controller.py@544 PS7, Line 544: my_client.close() Why not use the new syntax? Also applicable to the rest of the tests that call the .close() function. Also applies to similar cases below where the .close() function is called on the client. with self.create_impala_client_from_vector(vector) as my_client: -- To view, visit http://gerrit.cloudera.org:8080/22362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac07732424c16338e060c9392100b54337f11b8 Gerrit-Change-Number: 22362 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 10 Feb 2025 18:15:27 +0000 Gerrit-HasComments: Yes
