Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22362 )
Change subject: IMPALA-13682: Implement missing capabilities in ImpylaHS2Client ...................................................................... Patch Set 5: (1 comment) Will address remaining comments in next patch set. http://gerrit.cloudera.org:8080/#/c/22362/4/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22362/4/tests/common/impala_connection.py@469 PS4, Line 469: ROR, > Does this user parameter need to be unique for each call to execute_async, They don't need to be unique for each execute_async() call. For execute() call, however, I probably should check if the argument equals self.__user or not, and proceed accordingly. -- To view, visit http://gerrit.cloudera.org:8080/22362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac07732424c16338e060c9392100b54337f11b8 Gerrit-Change-Number: 22362 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 07 Feb 2025 20:10:07 +0000 Gerrit-HasComments: Yes
