Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22362 )

Change subject: IMPALA-13682: Implement missing capabilities in ImpylaHS2Client
......................................................................


Patch Set 6:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/22362/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22362/4//COMMIT_MSG@15
PS4, Line 15: execute_async
> Nit: execute_async
Done


http://gerrit.cloudera.org:8080/#/c/22362/4//COMMIT_MSG@50
PS4, Line 50: r
> Nit: remove
Done


http://gerrit.cloudera.org:8080/#/c/22362/4/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/22362/4/tests/common/impala_connection.py@267
PS4, Line 267:
> Please document the format of this parameter to help explain the intended u
Done


http://gerrit.cloudera.org:8080/#/c/22362/4/tests/common/impala_connection.py@469
PS4, Line 469: PENDING,
> They don't need to be unique for each execute_async() call.
Done



--
To view, visit http://gerrit.cloudera.org:8080/22362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac07732424c16338e060c9392100b54337f11b8
Gerrit-Change-Number: 22362
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Fri, 07 Feb 2025 20:30:46 +0000
Gerrit-HasComments: Yes

Reply via email to