Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22599 )
Change subject: IMPALA-13795: Support serving webUI content with gzip compression ...................................................................... Patch Set 2: -Code-Review (1 comment) http://gerrit.cloudera.org:8080/#/c/22599/2/be/src/util/codec.cc File be/src/util/codec.cc: http://gerrit.cloudera.org:8080/#/c/22599/2/be/src/util/codec.cc@105 PS2, Line 105: compressor->reset(new GzipCompressor(GzipCompressor::GZIP, mem_pool, reuse, : codec_info.compression_level_)); I didn't pay attention to this in my first review round, but after Riza added his comment, I took another look. Why to change this in the scope of this patch at all? Reading the description of IMPALA-13795, I don't see how this is relevant. I'd suggest to address this in a separate changelist instead of sneaking it into this patch. This update might have unintended consequences, and if you changed it, then I'd expect you provide adequate testing coverage. A proper venue for that would be a separate changelist, with corresponding tests coverage added, IMO. It's a good practice to address logically separate items in different patches instead of piling everything into a single patch. -- To view, visit http://gerrit.cloudera.org:8080/22599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I431088a30337bbef2c8d6e16dd15fb6572db0f15 Gerrit-Change-Number: 22599 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Fri, 28 Mar 2025 20:12:41 +0000 Gerrit-HasComments: Yes
