Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22599 )
Change subject: IMPALA-13795: Support serving webUI content with gzip compression ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22599/1/be/src/util/compress.h File be/src/util/compress.h: http://gerrit.cloudera.org:8080/#/c/22599/1/be/src/util/compress.h@66 PS1, Line 66: int compression_level_ > ... if there is a reason to circumvent the compression_level_ provided by > the library's user ... First, I'm not sure what you meant by this and how that's related to the visibility level of this field with regard to making decision of making it constant or not. Second, what that reason might be? Is this just some theoretical situation? Could you provide an example, please? As for the current code, nowhere I could see that 'compression_level_' is being updated, so why not to make it constant to express its immutability in the current implementation of GzipCompressor? -- To view, visit http://gerrit.cloudera.org:8080/22599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I431088a30337bbef2c8d6e16dd15fb6572db0f15 Gerrit-Change-Number: 22599 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Fri, 28 Mar 2025 19:50:20 +0000 Gerrit-HasComments: Yes
