Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/22599 )
Change subject: IMPALA-13795: Support serving webUI content with gzip compression ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22599/1/be/src/util/compress.h File be/src/util/compress.h: http://gerrit.cloudera.org:8080/#/c/22599/1/be/src/util/compress.h@66 PS1, Line 66: int compression_level_ > Just curious: why private visibility affects affect the decision on whether Within the implementation of compression, if there is a reason to circumvent the compression_level_ provided by the library's user, it should be possible. Thank you for the review. -- To view, visit http://gerrit.cloudera.org:8080/22599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I431088a30337bbef2c8d6e16dd15fb6572db0f15 Gerrit-Change-Number: 22599 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Fri, 28 Mar 2025 16:04:08 +0000 Gerrit-HasComments: Yes
