Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22599 )
Change subject: IMPALA-13795: Support serving webUI content with gzip compression ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22599/2/be/src/util/codec.cc File be/src/util/codec.cc: http://gerrit.cloudera.org:8080/#/c/22599/2/be/src/util/codec.cc@97 PS2, Line 97: Status Codec::CreateCompressor(MemPool* mem_pool, bool reuse, const CodecInfo& codec_info, : scoped_ptr<Codec>* compressor) { Please check following code path. Ideally, nothing but runtime-profile.cc should be impacted by this change. be/src/catalog/catalog-util.cc:348: RETURN_IF_ERROR(Codec::CreateCompressor(nullptr, false, codec_info, &compressor)); be/src/exec/parquet/hdfs-parquet-table-writer.cc:153: RETURN_IF_ERROR(Codec::CreateCompressor(nullptr, false, codec_info_, &compressor_)); be/src/runtime/tmp-file-mgr.cc:2024: Status status = Codec::CreateCompressor(nullptr, false, be/src/util/runtime-profile.cc:1623: RETURN_IF_ERROR(Codec::CreateCompressor(NULL, false, codec_info, &compressor)); http://gerrit.cloudera.org:8080/#/c/22599/2/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/22599/2/tests/webserver/test_web_pages.py@83 PS2, Line 83: " > flake8: E501 line too long (93 > 90 characters) Please address this. -- To view, visit http://gerrit.cloudera.org:8080/22599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I431088a30337bbef2c8d6e16dd15fb6572db0f15 Gerrit-Change-Number: 22599 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Fri, 28 Mar 2025 16:23:19 +0000 Gerrit-HasComments: Yes
