Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22901 )
Change subject: IMPALA-13912: Use SHARED_CLUSTER_ARGS in more custom cluster tests ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22901/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22901/5//COMMIT_MSG@19 PS5, Line 19: Some tests however do require restart due to the specific metrics being : tested. Such tests are defined with the 'force_restart' flag within the : 'with_args' decorator. I think this can be cleaner if we move out tests that require clean cluster to begin into its own test class, and use with_args decorator as usual (at method level). Thus, force_restart arg is not needed. I'm concern that adding yet another arg will confuse future test writer on how to properly write a new custom cluster tests. -- To view, visit http://gerrit.cloudera.org:8080/22901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c9115d4d47b9fe0bfd9dbda218aac2fb02dbd09 Gerrit-Change-Number: 22901 Gerrit-PatchSet: 5 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 15 May 2025 14:04:43 +0000 Gerrit-HasComments: Yes
