Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22901 )
Change subject: IMPALA-13912: Use SHARED_CLUSTER_ARGS in more custom cluster tests ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/22901/6/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22901/6/tests/common/custom_cluster_test_suite.py@589 PS6, Line 589: if PREVIOUS_CMD_STR == cmd_str I can see the benefit of detecting if current cmd_str is a repeat from previous cmd_str. I'd like to suggest adding this detection first, and log INFO message about it, as a separate patch. Then, we can follow up with correct refactoring next. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/22901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c9115d4d47b9fe0bfd9dbda218aac2fb02dbd09 Gerrit-Change-Number: 22901 Gerrit-PatchSet: 6 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 15 May 2025 15:07:52 +0000 Gerrit-HasComments: Yes
