Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/22901 )
Change subject: IMPALA-13912: Use SHARED_CLUSTER_ARGS in more custom cluster tests ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/22901/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22901/5//COMMIT_MSG@19 PS5, Line 19: 'with_args' decorator. NOTE: there might be more tests like that : revealed after running the tests in different order resulting in test : failures. > I think this can be cleaner if we move out tests that require clean cluster It's only for cases where a test goes after another test with exactly same cluster. Overall there's about 20 such tests. Grouping in classes is possible after IMPALA-13503, but that still requires manual work of grouping to be done. This one I see as a parallel mechanism to speed the existing codebase up, and 'force_restart' flag is rather a corner case. Anyway the idea is by Csaba, let's hear from him when he's back. http://gerrit.cloudera.org:8080/#/c/22901/6/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22901/6/tests/common/custom_cluster_test_suite.py@589 PS6, Line 589: if PREVIOUS_CMD_STR == cmd_str > I can see the benefit of detecting if current cmd_str is a repeat from prev Added a log message. Let's wait what Csaba has to say, this patch is more or less after his instructions. -- To view, visit http://gerrit.cloudera.org:8080/22901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c9115d4d47b9fe0bfd9dbda218aac2fb02dbd09 Gerrit-Change-Number: 22901 Gerrit-PatchSet: 7 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 15 May 2025 15:19:07 +0000 Gerrit-HasComments: Yes
