Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22901 )
Change subject: IMPALA-13912: Use SHARED_CLUSTER_ARGS in more custom cluster tests ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/22901/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22901/5//COMMIT_MSG@19 PS5, Line 19: 'with_args' decorator. NOTE: there might be more tests like that : revealed after running the tests in different order resulting in test : failures. > It's only for cases where a test goes after another test with exactly same I agree. This is probably not ideal, but still worth to have. We should put emphasize that proper test grouping should be preferred instead of putting 'force_restart' arg everywhere. -- To view, visit http://gerrit.cloudera.org:8080/22901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c9115d4d47b9fe0bfd9dbda218aac2fb02dbd09 Gerrit-Change-Number: 22901 Gerrit-PatchSet: 7 Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 15 May 2025 15:22:28 +0000 Gerrit-HasComments: Yes