Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22865 )
Change subject: IMPALA-13869: Support for 'hive.sql.query' property for Hive JDBC tables ...................................................................... Patch Set 2: (12 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22865/2/fe/src/main/java/org/apache/impala/catalog/TableLoader.java File fe/src/main/java/org/apache/impala/catalog/TableLoader.java: http://gerrit.cloudera.org:8080/#/c/22865/2/fe/src/main/java/org/apache/impala/catalog/TableLoader.java@235 PS2, Line 235: throw new TableLoadingException("Either 'hive.sql.table' or 'hive.sql.query' must be set."); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22865/2/fe/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java: http://gerrit.cloudera.org:8080/#/c/22865/2/fe/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java@110 PS2, Line 110: "For non-Hive JDBC tables, either 'table' or 'query' property must be set."); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22865/2/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/22865/2/tests/custom_cluster/test_ext_data_sources.py@84 PS2, Line 84: r flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22865/2/tests/custom_cluster/test_ext_data_sources.py@85 PS2, Line 85: D flake8: E501 line too long (105 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22865/2/tests/custom_cluster/test_ext_data_sources.py@100 PS2, Line 100: t flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22865/2/tests/custom_cluster/test_ext_data_sources.py@124 PS2, Line 124: r flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22865/2/tests/custom_cluster/test_ext_data_sources.py@125 PS2, Line 125: J flake8: E501 line too long (109 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22865/2/tests/custom_cluster/test_ext_data_sources.py@271 PS2, Line 271: t flake8: E501 line too long (164 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22865/2/tests/custom_cluster/test_ext_data_sources.py@299 PS2, Line 299: t flake8: E501 line too long (164 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22865/2/tests/custom_cluster/test_ext_data_sources.py@436 PS2, Line 436: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/22865/2/tests/custom_cluster/test_ext_data_sources.py@436 PS2, Line 436: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22865/2/tests/custom_cluster/test_ext_data_sources.py@507 PS2, Line 507: ) flake8: E501 line too long (92 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/22865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I039fcc1e008233a3eeed8d09554195fdb8c8706b Gerrit-Change-Number: 22865 Gerrit-PatchSet: 2 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 21 May 2025 07:07:43 +0000 Gerrit-HasComments: Yes
